<html>
<head><meta charset="utf-8"><title>cargo-bisect-rustc · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html">cargo-bisect-rustc</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="178884618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884618">(Oct 23 2019 at 18:58)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> about cargo-bisect-rustc that we have talked about previously ...</p>



<a name="178884643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884643">(Oct 23 2019 at 18:58)</a>:</h4>
<p>in particular from the document I've built</p>



<a name="178884650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884650">(Oct 23 2019 at 18:58)</a>:</h4>
<p>the documented tasks <a href="https://hackmd.io/Ipu9wSL4SCyx9_adR6GKLg?view" target="_blank" title="https://hackmd.io/Ipu9wSL4SCyx9_adR6GKLg?view">https://hackmd.io/Ipu9wSL4SCyx9_adR6GKLg?view</a></p>



<a name="178884680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884680">(Oct 23 2019 at 18:59)</a>:</h4>
<p>I'm not entirely sure about</p>



<a name="178884695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884695">(Oct 23 2019 at 18:59)</a>:</h4>
<div class="codehilite"><pre><span></span>* Use currently installed toolchain as end point (if no end is provided)
    * use current default toolchain
    * make sure this is easy to override with cargo +stage1 bisect-rustc
    * print nice error message for beta/stable as default, see task below
</pre></div>



<a name="178884707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884707">(Oct 23 2019 at 18:59)</a>:</h4>
<p>I meant, isn't that already done by the tool?</p>



<a name="178884731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884731">(Oct 23 2019 at 18:59)</a>:</h4>
<p>if no end it's provided it uses the latest nightly</p>



<a name="178884737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884737">(Oct 23 2019 at 18:59)</a>:</h4>
<p>ahh is it about installing it or not?</p>



<a name="178884832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884832">(Oct 23 2019 at 19:00)</a>:</h4>
<p>it definitely uses latest nightly, unsure if it checks if you have installed it or not</p>



<a name="178884845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178884845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178884845">(Oct 23 2019 at 19:00)</a>:</h4>
<p>but trying to understand exactly the task</p>



<a name="178885117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178885117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178885117">(Oct 23 2019 at 19:03)</a>:</h4>
<p>I think today we ignore your system config and use the most recent nightly</p>



<a name="178885125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178885125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178885125">(Oct 23 2019 at 19:03)</a>:</h4>
<p>which seems fine</p>



<a name="178885156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178885156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178885156">(Oct 23 2019 at 19:03)</a>:</h4>
<p>but we could be "better" by trying to figure out what you probably just tested with and look at the toolchain in the current directory</p>



<a name="178885309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178885309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178885309">(Oct 23 2019 at 19:05)</a>:</h4>
<p>so the idea is if you have a nightly installed use that one, otherwise do what we currently do?</p>



<a name="178888276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888276">(Oct 23 2019 at 19:40)</a>:</h4>
<p>Basically, yeah</p>



<a name="178888361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888361">(Oct 23 2019 at 19:41)</a>:</h4>
<p>I would just run <code>rustc -vV</code> and go from there rather than trying to interact with rustup or whatever</p>



<a name="178888437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888437">(Oct 23 2019 at 19:42)</a>:</h4>
<p>ok</p>



<a name="178888477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888477">(Oct 23 2019 at 19:42)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> also, what's <code>cargo-bisect-rustc --install date_or_commit</code> useful for?</p>



<a name="178888490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888490">(Oct 23 2019 at 19:42)</a>:</h4>
<p>I guess mainly because of the commit option?</p>



<a name="178888507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888507">(Oct 23 2019 at 19:42)</a>:</h4>
<p>otherwise you would just install using rustup, no?</p>



<a name="178888519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888519">(Oct 23 2019 at 19:43)</a>:</h4>
<p>If it's not nightly I would ignore (maybe with warning message)</p>



<a name="178888553"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888553" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888553">(Oct 23 2019 at 19:43)</a>:</h4>
<p>yes</p>



<a name="178888575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888575">(Oct 23 2019 at 19:43)</a>:</h4>
<p>I forget what that's for, but yeah I'd drop, people can just use rustup toolchain install master today I think</p>



<a name="178888646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888646">(Oct 23 2019 at 19:44)</a>:</h4>
<p>ok</p>



<a name="178888665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888665">(Oct 23 2019 at 19:44)</a>:</h4>
<p>doesn't hurt, I'm just trying to understand some things :)</p>



<a name="178888707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178888707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178888707">(Oct 23 2019 at 19:44)</a>:</h4>
<p>but yeah if you give that a commit it clones the repo and all that</p>



<a name="178970514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178970514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178970514">(Oct 24 2019 at 16:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I was wondering how were you typically testing the tool</p>



<a name="178970807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178970807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178970807">(Oct 24 2019 at 16:36)</a>:</h4>
<p>I, uh, didn't really</p>



<a name="178970815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178970815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178970815">(Oct 24 2019 at 16:36)</a>:</h4>
<p>:)</p>



<a name="178970832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178970832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178970832">(Oct 24 2019 at 16:36)</a>:</h4>
<p>I have no good ideas as to how to do so</p>



<a name="178971026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971026">(Oct 24 2019 at 16:39)</a>:</h4>
<p>yeah, I have some but I guess it doesn't worth the effort :)</p>



<a name="178971148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971148">(Oct 24 2019 at 16:40)</a>:</h4>
<p>I was doing some stuff but ended figuring out that some of the things may be "risky" to do</p>



<a name="178971182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971182">(Oct 24 2019 at 16:40)</a>:</h4>
<p>I've quoted "risky" because dunno it's just a tool</p>



<a name="178971200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971200">(Oct 24 2019 at 16:40)</a>:</h4>
<p>but you may end with your default intalled nightly removed or stuff like that</p>



<a name="178971228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971228">(Oct 24 2019 at 16:40)</a>:</h4>
<p>for instance, let me show you some stuff ...</p>



<a name="178971291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971291">(Oct 24 2019 at 16:41)</a>:</h4>
<p><a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L467-L472" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L467-L472">here</a> one nightly is removed</p>



<a name="178971345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971345">(Oct 24 2019 at 16:42)</a>:</h4>
<p>which is called from <a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503</a></p>



<a name="178971356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971356">(Oct 24 2019 at 16:42)</a>:</h4>
<p>inside <code>test</code> fn</p>



<a name="178971375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971375">(Oct 24 2019 at 16:42)</a>:</h4>
<p>or here <a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L799" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L799">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L799</a></p>



<a name="178971389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971389">(Oct 24 2019 at 16:42)</a>:</h4>
<p><a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L808" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L808">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L808</a></p>



<a name="178971440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971440">(Oct 24 2019 at 16:43)</a>:</h4>
<p>so on bisect fn also on bisect_nightlies</p>



<a name="178971553"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971553" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971553">(Oct 24 2019 at 16:44)</a>:</h4>
<p>in particular</p>



<a name="178971554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971554">(Oct 24 2019 at 16:44)</a>:</h4>
<p><a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L503</a></p>



<a name="178971558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971558">(Oct 24 2019 at 16:44)</a>:</h4>
<p>and</p>



<a name="178971579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971579">(Oct 24 2019 at 16:44)</a>:</h4>
<p><a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L798-L800" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L798-L800">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L798-L800</a></p>



<a name="178971593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971593">(Oct 24 2019 at 16:44)</a>:</h4>
<p>but unsure if that happens after every call to test</p>



<a name="178971624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971624">(Oct 24 2019 at 16:45)</a>:</h4>
<p>well this one <a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L876-L878" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L876-L878">https://github.com/rust-lang-nursery/cargo-bisect-rustc/blob/master/src/main.rs#L876-L878</a> is also after a test call</p>



<a name="178971686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971686">(Oct 24 2019 at 16:45)</a>:</h4>
<p>yeah, after all tests calls are remove calls so I guess the call to remove inside test could be removed</p>



<a name="178971705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971705">(Oct 24 2019 at 16:45)</a>:</h4>
<p>anyway, that was not my point</p>



<a name="178971706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971706">(Oct 24 2019 at 16:45)</a>:</h4>
<p>mhm</p>



<a name="178971877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971877">(Oct 24 2019 at 16:47)</a>:</h4>
<p>the thing I'm trying to decide is if I should just be deciding every remove call comparing rustc -vV output with the thing that the call wants to remove</p>



<a name="178971885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971885">(Oct 24 2019 at 16:47)</a>:</h4>
<p>probably that's the safest thing</p>



<a name="178971920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178971920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178971920">(Oct 24 2019 at 16:47)</a>:</h4>
<p>because I was just trying to track that through all the program and I see there are a lot of cases that causes me some confusion still</p>



<a name="178972052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972052">(Oct 24 2019 at 16:48)</a>:</h4>
<p>or maybe rather I can refactor a bit the code so make things a bit more clear to me :)</p>



<a name="178972224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972224">(Oct 24 2019 at 16:50)</a>:</h4>
<p>hm not sure I follow</p>



<a name="178972250"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972250" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972250">(Oct 24 2019 at 16:50)</a>:</h4>
<p>those removes all look mostly fine to me</p>



<a name="178972275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972275">(Oct 24 2019 at 16:50)</a>:</h4>
<p>it might be good to guard them with a "we installed this nightly this session"</p>



<a name="178972291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972291">(Oct 24 2019 at 16:51)</a>:</h4>
<p>that wouldn't be too hard (especially if we just stick it in a global static)</p>



<a name="178972890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972890">(Oct 24 2019 at 16:58)</a>:</h4>
<p>one of the things I've just said is that test fn is calling remove inside the test fn itself but also all the callers call it after calling test</p>



<a name="178972910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972910">(Oct 24 2019 at 16:58)</a>:</h4>
<p>I guess we could remove the call from inside test</p>



<a name="178972937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178972937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178972937">(Oct 24 2019 at 16:58)</a>:</h4>
<p>but anyway that's a minor thing which I don't care that much to be honest :)</p>



<a name="178973030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178973030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178973030">(Oct 24 2019 at 16:59)</a>:</h4>
<blockquote>
<p>it might be good to guard them with a "we installed this nightly this session"</p>
</blockquote>
<p>what I also was proposing is, instead of a global static, when installing or removing just calling rustc (or a cached version of the result) and check the date of that with the date of the thing you're trying to install/remove</p>



<a name="178973237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178973237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178973237">(Oct 24 2019 at 17:01)</a>:</h4>
<p>oh</p>



<a name="178973255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178973255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178973255">(Oct 24 2019 at 17:01)</a>:</h4>
<p>_that_ failure case I didn't consider</p>



<a name="178973261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178973261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178973261">(Oct 24 2019 at 17:01)</a>:</h4>
<p>seems fine though</p>



<a name="178992948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178992948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178992948">(Oct 24 2019 at 20:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> sorry, I got back to this</p>



<a name="178992971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178992971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178992971">(Oct 24 2019 at 20:19)</a>:</h4>
<p>couldn't put a lot of effort yet on it</p>



<a name="178992976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178992976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178992976">(Oct 24 2019 at 20:19)</a>:</h4>
<p>but <a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/37" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/37">https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/37</a></p>



<a name="178993057"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993057" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993057">(Oct 24 2019 at 20:20)</a>:</h4>
<p>there are some quick and dirty things that I'm not sure how important would be to refactor, to make it the best design in the world :P</p>



<a name="178993102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993102">(Oct 24 2019 at 20:20)</a>:</h4>
<p>anyway, let me know your thoughts about this first part</p>



<a name="178993127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993127">(Oct 24 2019 at 20:20)</a>:</h4>
<p>I didn't even test this, just open the thing for discussion</p>



<a name="178993158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993158">(Oct 24 2019 at 20:21)</a>:</h4>
<p>I may need to find at least a manual way to test some stuff, have a couple of scenarios because I'm gonna need that</p>



<a name="178993162"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993162" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993162">(Oct 24 2019 at 20:21)</a>:</h4>
<p>ideas are welcome</p>



<a name="178993315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993315">(Oct 24 2019 at 20:22)</a>:</h4>
<p>this <a href="https://github.com/spastorino/cargo-bisect-sample" target="_blank" title="https://github.com/spastorino/cargo-bisect-sample">https://github.com/spastorino/cargo-bisect-sample</a> was one of my first ideas, to have some examples around that I could use to play with</p>



<a name="178993329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178993329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178993329">(Oct 24 2019 at 20:22)</a>:</h4>
<p>also the README of the tool has another example like that one</p>



<a name="178995317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995317">(Oct 24 2019 at 20:40)</a>:</h4>
<p>btw after running some examples found some mistake, gonna fix it tomorrow probably</p>



<a name="178995600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995600">(Oct 24 2019 at 20:43)</a>:</h4>
<p>okay reping me here probably when that's done</p>



<a name="178995610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995610">(Oct 24 2019 at 20:43)</a>:</h4>
<p>I might take a look later today at the code though</p>



<a name="178995754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995754">(Oct 24 2019 at 20:45)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="178995817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995817">(Oct 24 2019 at 20:46)</a>:</h4>
<p>I think there are usages of toolchain dates that I didn't get correct because this is not doing the right thing</p>



<a name="178995829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995829">(Oct 24 2019 at 20:46)</a>:</h4>
<p>but most of the things that I need to code are there</p>



<a name="178995845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/178995845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#178995845">(Oct 24 2019 at 20:46)</a>:</h4>
<p>probably some bits are wrong, gonna check out tomorrow</p>



<a name="179018068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179018068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179018068">(Oct 25 2019 at 02:59)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> as you may have seen on the other thread I've just tested the stuff and seems to be working fine :)</p>



<a name="179040437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179040437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179040437">(Oct 25 2019 at 11:12)</a>:</h4>
<p>this  "other thread" reminded me I promised to add some documentation about bors' commits, so here's <a href="https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/38" target="_blank" title="https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/38">https://github.com/rust-lang-nursery/cargo-bisect-rustc/pull/38</a>  <span class="user-mention" data-user-id="116122">@simulacrum</span> -- and I <a href="#narrow/stream/131828-t-compiler/topic/static.20lifetime.20in.20impl.20trait.20.2365582/near/179034991" title="#narrow/stream/131828-t-compiler/topic/static.20lifetime.20in.20impl.20trait.20.2365582/near/179034991">mentioned here</a> we might need to do something in <code>cargo-bisect-rustc</code> to help with bisections hitting the very frequent rollups, and which is a use-case I don't think I've seen that mentioned in the requirements hackmds here ?</p>



<a name="179042368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042368">(Oct 25 2019 at 11:52)</a>:</h4>
<p>we should have less rollups :/</p>



<a name="179042376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042376">(Oct 25 2019 at 11:52)</a>:</h4>
<p>Though I was thinking this morning that one possible avenue to look at is to make r+ auto-trigger a bors try build</p>



<a name="179042393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042393">(Oct 25 2019 at 11:53)</a>:</h4>
<p>that would give us by-PR bisectionish within a rollup (though somewhat manual) -- they wouldn't be linear -- but it might be good enough</p>



<a name="179042399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042399">(Oct 25 2019 at 11:53)</a>:</h4>
<p>can we maybe use the PR artifacts ?</p>



<a name="179042471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042471">(Oct 25 2019 at 11:54)</a>:</h4>
<p>(if some of them are usable, that is, I don't assume a new nightly is built by the PR builders)</p>



<a name="179042531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042531">(Oct 25 2019 at 11:55)</a>:</h4>
<p>yeah maybe the try build could be good enough indeed</p>



<a name="179042587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042587">(Oct 25 2019 at 11:56)</a>:</h4>
<p>PRs don't on their own produce artifacts, that's what you need a try build for</p>



<a name="179042618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042618">(Oct 25 2019 at 11:56)</a>:</h4>
<p>in theory any rollup could trigger try builds for each of its contained PRs, even, in parallel but with the proper ordering so that it "looks" like the rollup merges are actually bors merges</p>



<a name="179042635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042635">(Oct 25 2019 at 11:57)</a>:</h4>
<p>I expect that we could handle ~8 more builders (or whatever the average rollup size is) on our CI</p>



<a name="179042696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042696">(Oct 25 2019 at 11:58)</a>:</h4>
<p>that seems like it could work :)</p>



<a name="179042767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042767">(Oct 25 2019 at 11:59)</a>:</h4>
<p>it feels like rollups would be a pretty big roadblock to a bisection ICE-breakers team, and this could help out a lot</p>



<a name="179042871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042871">(Oct 25 2019 at 12:01)</a>:</h4>
<p>a _lot_ of the time once you know what rollup it is guessing is not too hard</p>



<a name="179042880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179042880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179042880">(Oct 25 2019 at 12:01)</a>:</h4>
<p>and I imagine it'd be super helpful to even get just the rollup</p>



<a name="179043089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179043089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179043089">(Oct 25 2019 at 12:05)</a>:</h4>
<p>sure, I agree, and even if icebreakers may not be able to guess, the team can do so once the rollup is known</p>



<a name="179043266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179043266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179043266">(Oct 25 2019 at 12:07)</a>:</h4>
<p>with the "rollup @try"s there hopefully would be almost no need to do so, even when the rollup contains more than one PR in the same area which sometimes happen iirc</p>



<a name="179071770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179071770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179071770">(Oct 25 2019 at 17:36)</a>:</h4>
<p><span class="user-mention" data-user-id="116113">@lqd</span> unsure I understood correctly what you issue are you seeing with rollups</p>



<a name="179071792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179071792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179071792">(Oct 25 2019 at 17:37)</a>:</h4>
<p>I guess that the tool is going to see that as a unit</p>



<a name="179071805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179071805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179071805">(Oct 25 2019 at 17:37)</a>:</h4>
<p>the issue is that you don't want that to be a unit?</p>



<a name="179071851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179071851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179071851">(Oct 25 2019 at 17:37)</a>:</h4>
<p>I meant, for sure it would be better, but shouldn't in rollups in general be included non risky things?</p>



<a name="179075671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179075671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179075671">(Oct 25 2019 at 18:18)</a>:</h4>
<p>I'm not sure I understand, the more rollups we do, the more likely they are going to be the PR that cargo-bisect-rustc finds; rollups are because CI would otherwise take too long, and bugs requiring bisection can be "non-risky" and included in rollups. It seems nowadays  it's more the norm than the exception. What I meant is: if the tool could help continue the process instead of stopping at the rollup PR, as it does today, it would help avoid the manual process that follows of sifting through the 5-10 rolled-up PRs. And this is is looking more and more likely to happen in the future as we use rollups a lot</p>



<a name="179075819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179075819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179075819">(Oct 25 2019 at 18:20)</a>:</h4>
<p>yes, that's what I got from your message but wasn't sure :)</p>



<a name="179075831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179075831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179075831">(Oct 25 2019 at 18:20)</a>:</h4>
<p>we can add that to the md notes</p>



<a name="179075909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179075909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179075909">(Oct 25 2019 at 18:21)</a>:</h4>
<p>it's not absolutely indispensable of course, as you've seen we've managed fine without it til now :)</p>



<a name="179080758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179080758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179080758">(Oct 25 2019 at 19:22)</a>:</h4>
<p>btw, <span class="user-mention" data-user-id="116009">@nikomatsakis</span> yesterday's code example with the new jumps</p>



<a name="179080761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179080761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179080761">(Oct 25 2019 at 19:22)</a>:</h4>
<div class="codehilite"><pre><span></span>[santiago@galago cargo-bisect-sample2 (master)]$ ../cargo-bisect-rustc/target/debug/cargo-bisect-rustc
checking nightly-2019-10-16
checking nightly-2019-10-14
std for x86_64-unknown-linux-gnu: 17.88 MB / 17.88 MB [=================================================================================================================================================================] 100.00 % 4.84 MB/s
uninstalling nightly-2019-10-14
uninstalling nightly-2019-10-14
checking nightly-2019-10-12
std for x86_64-unknown-linux-gnu: 17.36 MB / 17.36 MB [=================================================================================================================================================================] 100.00 % 7.47 MB/s
uninstalling nightly-2019-10-12
uninstalling nightly-2019-10-12
checking nightly-2019-10-10
std for x86_64-unknown-linux-gnu: 177.63 MB / 177.63 MB [===============================================================================================================================================================] 100.00 % 7.75 MB/s
uninstalling nightly-2019-10-10
uninstalling nightly-2019-10-10
checking nightly-2019-10-08
std for x86_64-unknown-linux-gnu: 176.71 MB / 176.71 MB [===============================================================================================================================================================] 100.00 % 6.64 MB/s
uninstalling nightly-2019-10-08
uninstalling nightly-2019-10-08
checking nightly-2019-10-01
std for x86_64-unknown-linux-gnu: 172.77 MB / 172.77 MB [===============================================================================================================================================================] 100.00 % 6.68 MB/s
uninstalling nightly-2019-10-01
uninstalling nightly-2019-10-01                                                                                                                                                                                                         [5/57]
checking nightly-2019-09-24
std for x86_64-unknown-linux-gnu: 175.85 MB / 175.85 MB [===============================================================================================================================================================] 100.00 % 7.86 MB/s
uninstalling nightly-2019-09-24
uninstalling nightly-2019-09-24
checking nightly-2019-09-17
uninstalling nightly-2019-09-17
checking nightly-2019-09-16
std for x86_64-unknown-linux-gnu: 175.97 MB / 175.97 MB [===============================================================================================================================================================] 100.00 % 7.85 MB/s
uninstalling nightly-2019-09-16
uninstalling nightly-2019-09-16
checking nightly-2019-09-09
std for x86_64-unknown-linux-gnu: 174.41 MB / 174.41 MB [===============================================================================================================================================================] 100.00 % 7.56 MB/s
uninstalling nightly-2019-09-09
uninstalling nightly-2019-09-09
checking nightly-2019-09-02
std for x86_64-unknown-linux-gnu: 175.62 MB / 175.62 MB [===============================================================================================================================================================] 100.00 % 7.86 MB/s
uninstalling nightly-2019-09-02
uninstalling nightly-2019-09-02
checking nightly-2019-08-26
std for x86_64-unknown-linux-gnu: 173.10 MB / 173.10 MB [===============================================================================================================================================================] 100.00 % 7.57 MB/s
uninstalling nightly-2019-08-26
uninstalling nightly-2019-08-26
checking nightly-2019-08-12
std for x86_64-unknown-linux-gnu: 169.94 MB / 169.94 MB [===============================================================================================================================================================] 100.00 % 6.52 MB/s
uninstalling nightly-2019-08-12
verifying the start of the range does not reproduce the regression
std for x86_64-unknown-linux-gnu: 169.94 MB / 169.94 MB [===============================================================================================================================================================] 100.00 % 8.02 MB/s
uninstalling nightly-2019-08-12
uninstalling nightly-2019-08-12
tested nightly-2019-08-12, got No
confirmed the start of the range does not reproduce the regression
verifying the end of the range reproduces the regression
std for x86_64-unknown-linux-gnu: 173.10 MB / 173.10 MB [===============================================================================================================================================================] 100.00 % 7.91 MB/s
uninstalling nightly-2019-08-26
uninstalling nightly-2019-08-26
tested nightly-2019-08-26, got Yes
confirmed the end of the range reproduces the regression
std for x86_64-unknown-linux-gnu: 173.53 MB / 173.53 MB [===============================================================================================================================================================] 100.00 % 6.65 MB/s
uninstalling nightly-2019-08-19
uninstalling nightly-2019-08-19
tested nightly-2019-08-19, got No
std for x86_64-unknown-linux-gnu: 173.78 MB / 173.78 MB [===============================================================================================================================================================] 100.00 % 7.55 MB/s
uninstalling nightly-2019-08-22
uninstalling nightly-2019-08-22
tested nightly-2019-08-22, got Yes
std for x86_64-unknown-linux-gnu: 173.91 MB / 173.91 MB [===============================================================================================================================================================] 100.00 % 1.21 MB/s
uninstalling nightly-2019-08-20
uninstalling nightly-2019-08-20
tested nightly-2019-08-20, got No
std for x86_64-unknown-linux-gnu: 173.65 MB / 173.65 MB [===============================================================================================================================================================] 100.00 % 7.55 MB/s
uninstalling nightly-2019-08-21
uninstalling nightly-2019-08-21
tested nightly-2019-08-21, got Yes
searched toolchains nightly-2019-08-12 through nightly-2019-08-26
regression in nightly-2019-08-21
[santiago@galago cargo-bisect-sample2 (master)]$
</pre></div>



<a name="179080784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179080784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179080784">(Oct 25 2019 at 19:23)</a>:</h4>
<p>it nows catches the regression and does not jump over the "correct" nightlies</p>



<a name="179090161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090161">(Oct 25 2019 at 21:20)</a>:</h4>
<div class="codehilite"><pre><span></span>[santiago@galago cargo-bisect-sample2 (master)]$ ../cargo-bisect-rustc/target/debug/cargo-bisect-rustc                                                                                                                                 [7/835]
checking nightly-2019-10-16 from the currently installed default nightly toolchain as the last failure
checking nightly-2019-10-14
std for x86_64-unknown-linux-gnu: 17.88 MB / 17.88 MB [=================================================================================================================================================================] 100.00 % 8.29 MB/s
uninstalling nightly-2019-10-14
checking nightly-2019-10-12
std for x86_64-unknown-linux-gnu: 17.36 MB / 17.36 MB [=================================================================================================================================================================] 100.00 % 7.50 MB/s
uninstalling nightly-2019-10-12
checking nightly-2019-10-10
std for x86_64-unknown-linux-gnu: 177.63 MB / 177.63 MB [===============================================================================================================================================================] 100.00 % 7.72 MB/s
uninstalling nightly-2019-10-10
checking nightly-2019-10-08
std for x86_64-unknown-linux-gnu: 176.71 MB / 176.71 MB [===============================================================================================================================================================] 100.00 % 8.05 MB/s
uninstalling nightly-2019-10-08
checking nightly-2019-10-01
std for x86_64-unknown-linux-gnu: 172.77 MB / 172.77 MB [===============================================================================================================================================================] 100.00 % 7.78 MB/s
uninstalling nightly-2019-10-01
checking nightly-2019-09-24
std for x86_64-unknown-linux-gnu: 175.85 MB / 175.85 MB [===============================================================================================================================================================] 100.00 % 7.97 MB/s
uninstalling nightly-2019-09-24
checking nightly-2019-09-17
uninstalling nightly-2019-09-17
checking nightly-2019-09-16
std for x86_64-unknown-linux-gnu: 175.97 MB / 175.97 MB [===============================================================================================================================================================] 100.00 % 7.45 MB/s
uninstalling nightly-2019-09-16
checking nightly-2019-09-10
std for x86_64-unknown-linux-gnu: 174.98 MB / 174.98 MB [===============================================================================================================================================================] 100.00 % 6.61 MB/s
uninstalling nightly-2019-09-10
checking nightly-2019-09-03
std for x86_64-unknown-linux-gnu: 175.47 MB / 175.47 MB [===============================================================================================================================================================] 100.00 % 7.06 MB/s
uninstalling nightly-2019-09-03
checking nightly-2019-08-27
std for x86_64-unknown-linux-gnu: 174.36 MB / 174.36 MB [===============================================================================================================================================================] 100.00 % 7.50 MB/s
uninstalling nightly-2019-08-27
checking nightly-2019-08-13
std for x86_64-unknown-linux-gnu: 173.10 MB / 173.10 MB [===============================================================================================================================================================] 100.00 % 7.28 MB/s
uninstalling nightly-2019-08-13
verifying the start of the range does not reproduce the regression
std for x86_64-unknown-linux-gnu: 173.10 MB / 173.10 MB [===============================================================================================================================================================] 100.00 % 8.25 MB/s
uninstalling nightly-2019-08-13
tested nightly-2019-08-13, got No
confirmed the start of the range does not reproduce the regression
verifying the end of the range reproduces the regression
std for x86_64-unknown-linux-gnu: 174.36 MB / 174.36 MB [===============================================================================================================================================================] 100.00 % 8.21 MB/s
uninstalling nightly-2019-08-27
tested nightly-2019-08-27, got Yes
confirmed the end of the range reproduces the regression
std for x86_64-unknown-linux-gnu: 173.91 MB / 173.91 MB [===============================================================================================================================================================] 100.00 % 7.72 MB/s
uninstalling nightly-2019-08-20
tested nightly-2019-08-20, got No
std for x86_64-unknown-linux-gnu: 173.88 MB / 173.88 MB [===============================================================================================================================================================] 100.00 % 7.44 MB/s
uninstalling nightly-2019-08-23
tested nightly-2019-08-23, got Yes
std for x86_64-unknown-linux-gnu: 173.65 MB / 173.65 MB [===============================================================================================================================================================] 100.00 % 7.66 MB/s
uninstalling nightly-2019-08-21
tested nightly-2019-08-21, got Yes
searched toolchains nightly-2019-08-13 through nightly-2019-08-27
regression in nightly-2019-08-21
[santiago@galago cargo-bisect-sample2 (master)]$
</pre></div>



<a name="179090165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090165">(Oct 25 2019 at 21:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> a bit cleaner :)</p>



<a name="179090280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090280">(Oct 25 2019 at 21:21)</a>:</h4>
<p>one thing I've actually wanted to suggest -- not sure how feasible it is -- but to give some sort of idea of "what we tested" and maybe even a "what we know" throughout the process</p>



<a name="179090296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090296">(Oct 25 2019 at 21:22)</a>:</h4>
<p>not sure how useful that'd be</p>



<a name="179090410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090410">(Oct 25 2019 at 21:22)</a>:</h4>
<p>I sometimes feel like the tool is very much a black box which is not great</p>



<a name="179090422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090422">(Oct 25 2019 at 21:22)</a>:</h4>
<p>I also wonder if renaming it might make sense -- we're not really bisecting in the common case</p>



<a name="179090431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090431">(Oct 25 2019 at 21:22)</a>:</h4>
<p>even if I think about it as bisection :)</p>



<a name="179090614"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090614" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090614">(Oct 25 2019 at 21:26)</a>:</h4>
<p><code>cargo-rustc-regression</code>?</p>



<a name="179090654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090654">(Oct 25 2019 at 21:27)</a>:</h4>
<p>something like that, yeah</p>



<a name="179090669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090669">(Oct 25 2019 at 21:27)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> from me, do you agree with the naming?</p>



<a name="179090678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090678">(Oct 25 2019 at 21:27)</a>:</h4>
<p>any other better idea?</p>



<a name="179090934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090934">(Oct 25 2019 at 21:31)</a>:</h4>
<p>Seems fine. Might be good to ask broader feedback, maybe someone has better ideas. I'm not <em>too</em> happy with it, though I think it's already pretty good</p>



<a name="179090944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179090944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179090944">(Oct 25 2019 at 21:31)</a>:</h4>
<p>maybe something like "bug finder" could work</p>



<a name="179093623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/cargo-bisect-rustc/near/179093623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/cargo-bisect-rustc.html#179093623">(Oct 25 2019 at 22:14)</a>:</h4>
<p>(deleted)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>